Home → Suggestions →

Adding ignoreFailures property for FlexUnit

• Edit

Nicolas Estrada

28 Feb, 2014 05:42 PM

Hello,

I don't really know how to do a 'pull request' but I would if someone could point me to a simple tutorial. Anyhow I would like to be able to build a Flex project without failures if the FlexUnit part fails, which is currently the case as it always throws an exception. Anyhow if anyone is interested here is the diff from the latest master. Does this seem sound or does everyone using gradlefx have 100% tests always? :)

1. 1 Posted by Nicolas Estrada on 28 Feb, 2014 05:42 PM

   

   Captcha got me :P

   • gradlefx.diff 1.92 KB
   • Edit

2. Support Staff 2 Posted by Yennick Trevels on 01 Mar, 2014 09:53 AM

   

   Hi Nicolas,

   Your diff looks good, thanks for contributing!

   Here's a tutorial on how to create a pull request in Github: https://help.github.com/articles/creating-a-pull-request

   When you select the destination branch, try to select the 'develop' branch of GradleFx.

   • Edit

3. 3 Posted by Nicolas Estrada on 04 Mar, 2014 05:08 PM

   

   https://github.com/GradleFx/GradleFx/pull/127

   However when I tried to push into the develop branch, it didn't allow me for some weird push-ahead reason. Anyhow I'll look more into it or start reading on using git (I've been dormant way to long on the subject ;))

   • Edit

4. Support Staff 4 Posted by Yennick Trevels on 04 Mar, 2014 06:06 PM

   

   Thanks!
   I can always manually merge your pull request in any branch I want, it's just without the convenience of the automatic merge. So it's not that big a deal :)

   • Edit